Hacker Newsnew | past | comments | ask | show | jobs | submitlogin
[dupe] Gitter – Chat, for GitHub (gitter.im)
71 points by ejdyksen on Feb 20, 2014 | hide | past | favorite | 37 comments


Looks really nice but you guys ask for too many permissions! SSH keys?? http://cl.ly/U1pP


Hey,

I've answered this numerous times in this thread, but I'll say it again, very loudly and very definitively: WE DO NOT WRITE TO YOUR SSH KEYS, EVER. EVER. EVER. We don't even read them.

Unfortunately, as beautiful as GitHub's API is, they've got their scopes for permissions completely wrong and we know they are working to fix this.

Short answer: https://gitter.zendesk.com/hc/en-us/articles/200178961-Why-d...

Long answer: https://gitter.zendesk.com/hc/en-us/articles/200176672-Authe...

Mike


I see your explanation in https://gitter.im/login/explain and it suggests a business solution that doesn't require me to believe the promises of someone I don't yet trust.

"In order to create a good first-time user experience that allows people to create and join chat rooms for public repositories and organisations... [the rest of the technical explanation]".

Stop doing this.

Make this feature optional. I don't even want a public chat room for my company's private repo.


It has nothing to do with your company's private repo, it has to do with getting a list of ORGS you belong to.

In fact chats for private repos is a completely separate matter and we allow users to upgrade their access to GitHub's repo scope if they want access to private repos.

Otherwise we'd have to do: * signup (only public repos) * upgrade permissions -> org chats * upgrade permissions -> repo chats

And so then users need to understand three levels of permissions and scope and I don't want to burden people with that level of cognitive overload. It's hard enough to explain to people that they need to elevate privileges to get private repo access.

Whilst a few people share your view, we've had nearly 10,000 grant us this access in a very short space of time and so it's not massively affecting our product right now and we have confidence in the future that GitHub will change their permissions and introduce a read-only permission that we will then switch to.


I don't want to sound like a parrot here, but I'm VERY excited about the feature set of your product but I'm not going to try it with the current permissions model.

Do you have any communication channel into Github through which you can let them know that their permissions model stands to kill your business?


Yeah we've been talking to them. We've had nearly 10,000 people sign up, given we only launched very recently, I wouldn't say this is killing our business at the moment and we're confident they will deliver a solution in the future.

It would be exceptionally difficult for us to add/delete an SSH key by a bug, because we don't ever call or reference keys anywhere and there's really not much else we do other than GET items.


I don't doubt your sincerity. Unfortunately, all of us have bugs, and if that bug in one step from write access to repos -- that is unacceptable.

I hope that Github is reactive enough to get permissions setup in a failsafe manner so I can give this a spin.


Hey, thanks for posting. Mike here from Gitter.

I know a lot of this audience are pretty bullish on IRC and so we're also busy testing an IRC bridge for Gitter. Once you've signed up, feel free to go to https://irc.gitter.im and give it a whirl.

Feel free to leave any feedback on Gitter here or get in touch with us via our chat room: https://gitter.im/gitterHQ/gitter or http://support.gitter.im


Mike? Why did you have to change you name? He's the one who sucks!


This is really cool, but is there a reason why the authorization permissions requires r/w access to: Private email addresses, and SSH keys?


Hey Mike,

We don't ever write anything to your profile. As explained in the link below, this is a standard GitHub permission.

PS your SSH keys are 100% public: https://api.github.com/users/mikexstudios/keys

Mike

Short answer: https://gitter.zendesk.com/hc/en-us/articles/200178961-Why-d...

Long answer: https://gitter.zendesk.com/hc/en-us/articles/200176672-Authe...


Any idea if GitHub will ever alter the way that works so you can avoid it giving you write access. I was all ready to give Gitter a go until I saw the permissions that would be granted. Sure you're trust worthy but us IT types can be paranoid ;-)


Hi, this is Andrew from Gitter.

And we completely understand. We're waiting on Github to update their OAuth scopes, and we understand that they're working on it.

If you're not comfortable with the OAuth permissions Gitter requires, you could try Gitter's sister product, Troupe https://trou.pe. It's got most of the same features, but with less Github integration and no markdown or syntax highlighting.


They actually recently announced some more granular scopes for working with webhooks.

So we hope for more to come for other areas of the API.


The idea that this gives write access to my SSH keys is still scary. Not that I don't trust your service, but what if somebody attacks it and adds malicious keys?

Or does write access not include SSH keys?


You could always be hacked. It's a danger to provide those permissions. (I understand that there's not much more you can do about it.)


It is apparently a limitation in the GitHub access levels:

https://gitter.zendesk.com/hc/en-us/articles/200176672-Authe...

Which is unfortunate, because I'd like to try gitter but I'm not willing to mess around with my github account like that.


Pretty cool but I can't see having another chat client on top of Hipchat. Wish there was some way to bake this into Hipchat since the features look awesome. Great work!


Thanks! We've got a few people migrating from Campfire and Hipchat to us... :)


I have been using this since the beginning for my open source project https://github.com/pksunkara/alpaca. They provide very good support. And the features are awesome.

Short story, Gitter is awesome!

https://gitter.im/pksunkara/alpaca


Thanks for all the brilliant support Pavan!

In fact, Gitter uses Pavan's excellent Octonode library (https://github.com/pksunkara/octonode) for all it's communications with Github.


We've been testing it for Brackets:

https://gitter.im/adobe/brackets

It's a really cool service and I think one of the big considerations for us right now is that our freenode channel (#brackets) has 86 people in it as I type this. We've potentially got some inertia to overcome.


Could you guys add the Webpage Icons[1]?

[1] - https://developer.apple.com/library/ios/documentation/AppleA...


Great request, will certainly look into it. We'll also have an iOS app out soon.


That was going to be my original question until I actually used my reading skills.


Awesome :)

I just integrated with sorl-thumbnail, I don't know if it will be a fully replacement for our IRC channel, however I'm sure most of the devs will give it a try.

Gitter Room: https://gitter.im/mariocesar/sorl-thumbnail


Feel free to give our IRC bridge a go to. It's very new and still very much in test phase.

https://irc.gitter.im

Let us know you get along with it: https://gitter.im/gitterHQ/gitter http://support.gitter.im

Mike


Reminds me a lot of Slack[1], but the gh-flavored-markdown and tighter issue and CI integration make Gitter stand out.

Any chance of BitBucket integration?

[1] (http://slack.com/)


BitBucket is coming soon! Follow us on twitter for updates (@gitchat)


Is there a privacy policy or ToS? I don't see one on the site.


It looks great, I'd love to try it, but I am not comfortable with how many permissions it requires on my Github account.


Hey,

We don't use those permissions, unfortunately as good as GitHub's API is, their scopes are very limited.

short answer: https://gitter.zendesk.com/hc/en-us/articles/200178961-Why-d...

long answer: https://gitter.zendesk.com/hc/en-us/articles/200176672-Authe...


Maybe a good solution would be to request a less privileged token if the user doesn't want integration with private repos. Then, if they want to upgrade to integration with private repos they need to get a new oauth token with the relevant privileges.

I'd love to try this service out, but I also don't want to hand out oauth tokens that can read my ssh keys.

EDIT: Just read more comments and saw that my github ssh keys are completely public. I guess that makes sense since they are public keys!


Hi, this is Andrew from Gitter.

If you're not comfortable with the OAuth permissions Gitter requires, you're welcome to try it's sister product, Troupe https://trou.pe. It's got most of the same features, but with less Github integration.


How do this compare to HipChat? Seems interesting.


Where's the privacy policy?


[deleted]


Hi,

We don't read, not write anything to do with your SSH keys. In fact, we don't write anything to your profile at all. This is a limitation of GitHub's API scope.

Short answer: https://gitter.zendesk.com/hc/en-us/articles/200178961-Why-d...

Long answer:https://gitter.zendesk.com/hc/en-us/articles/200176672-Authe...

PS, your SSH keys are 100% public: https://api.github.com/users/masom/keys

Mike




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: